Contributing

We are happy you have decided to contribute to twine.

Please see the GitHub repository for code and more documentation, and the official Python Packaging User Guide for user documentation. You can also join #pypa or #pypa-dev on Freenode, or the distutils-sig mailing list, to ask questions or get involved.

Getting started

We recommend you use a virtual environment, so that twine and its dependencies do not interfere with other packages installed on your machine.

Clone the twine repository from GitHub, then make and activate a virtual environment that uses Python 3.6 or newer as the default Python. For example:

cd /path/to/your/local/twine
python3.6 -m venv venv
source venv/bin/activate

Then, run the following command:

pip install -e .

Now, in your virtual environment, twine is pointing at your local copy, so when you make changes, you can easily see their effect.

We use tox to run tests, check code style, and build the documentation. To install tox in your active virtual environment, run:

pip install tox

Building the documentation

Additions and edits to twine’s documentation are welcome and appreciated.

To preview the docs while you’re making changes, run:

tox -e watch-docs

Then open a web browser to http://127.0.0.1:8000.

When you’re done making changes, lint and build the docs locally before making a pull request. In your active virtual environment, run:

tox -e docs

The HTML of the docs will be written to docs/_build/html.

Code style

To automatically reformat your changes with isort and black, run:

tox -e format

To detect any remaining code smells with flake8, run:

tox -e lint

To perform strict type-checking using mypy, run:

tox -e types

Any errors from lint or types need to be fixed manually.

Additionally, we prefer that import statements be used for packages and modules only, rather than individual classes or functions.

Testing

We use pytest for writing and running tests.

To run the tests in your virtual environment, run:

tox -e py

To pass options to pytest, e.g. the name of a test, run:

tox -e py -- tests/test_upload.py::test_exception_for_http_status

Twine is continuously tested against Python 3.6, 3.7, 3.8, and 3.9 using GitHub Actions. To run the tests against a specific version, e.g. Python 3.6, you will need it installed on your machine. Then, run:

tox -e py36

To run the “integration” tests of uploading to real package indexes, run:

tox -e integration

To run the tests against all supported Python versions, check code style, and build the documentation, run:

tox

Submitting changes

  1. Fork the GitHub repository.

  2. Make a branch off of master and commit your changes to it.

  3. Run the tests, check code style, and build the docs as described above.

  4. Optionally, add your name to the end of the AUTHORS file using the format Name <email@domain.com> (url), where the (url) portion is optional.

  5. Submit a pull request to the master branch on GitHub, referencing an open issue.

  6. Add a changelog entry.

Changelog entries

The docs/changelog.rst file is built by towncrier from files in the changelog/ directory. To add an entry, create a file in that directory named {number}.{type}.rst, where {number} is the pull request number, and {type} is feature, bugfix, doc, removal, or misc.

For example, if your PR number is 1234 and it’s fixing a bug, then you would create changelog/1234.bugfix.rst. PRs can span multiple categories by creating multiple files: if you added a feature and deprecated/removed an old feature in PR #5678, you would create changelog/5678.feature.rst and changelog/5678.removal.rst.

A changelog entry is meant for end users and should only contain details relevant to them. In order to maintain a consistent style, please keep the entry to the point, in sentence case, shorter than 80 characters, and in an imperative tone. An entry should complete the sentence “This change will …”. If one line is not enough, use a summary line in an imperative tone, followed by a description of the change in one or more paragraphs, each wrapped at 80 characters and separated by blank lines.

You don’t need to reference the pull request or issue number in a changelog entry, since towncrier will add a link using the number in the file name, and the pull request should reference an issue number. Similarly, you don’t need to add your name to the entry, since that will be associated with the pull request.

Changelog entries are rendered using reStructuredText, but they should only have minimal formatting (such as ``monospaced text``).

Architectural overview

Twine is a command-line tool for interacting with PyPI securely over HTTPS. Its three purposes are to be:

  1. A user-facing tool for publishing on pypi.org

  2. A user-facing tool for publishing on other Python package indexes (e.g., devpi instances)

  3. A useful API for other programs (e.g., zest.releaser) to call for publishing on any Python package index

Currently, twine has two principle functions: uploading new packages and registering new projects (register is no longer supported on PyPI, and is in Twine for use with other package indexes).

Its command line arguments are parsed in twine/cli.py. The code for registering new projects is in twine/commands/register.py, and the code for uploading is in twine/commands/upload.py. The file twine/package.py contains a single class, PackageFile, which hashes the project files and extracts their metadata. The file twine/repository.py contains the Repository class, whose methods control the URL the package is uploaded to (which the user can specify either as a default, in the .pypirc file, or pass on the command line), and the methods that upload the package securely to a URL.

Where Twine gets configuration and credentials

A user can set the repository URL, username, and/or password via command line, .pypirc files, environment variables, and keyring.

Adding a maintainer

A checklist for adding a new maintainer to the project.

  1. Add them as a Member in the GitHub repo settings.

  2. Get them Test PyPI and canon PyPI usernames and add them as a Maintainer on our Test PyPI project and canon PyPI.

Making a new release

A checklist for creating, testing, and distributing a new version.

  1. Choose a version number, e.g. 3.3.0.

  2. Run tox -e changelog -- --version {version} to build docs/changelog.rst.

  3. Commit and open a pull request for review.

  4. Merge the pull request, and ensure the GitHub Actions build passes.

  5. Create a new git tag with git tag -m "Release v{version}" {version}.

  6. Push the new tag with git push upstream {version}.

  7. Watch the release in GitHub Actions.

  8. Send announcement email to distutils-sig mailing list and celebrate.

Future development

See our open issues.

In the future, pip and twine may merge into a single tool; see ongoing discussion.